Skip to content

FAQGen Megaservice#425

Merged
kevinintel merged 27 commits intoopea-project:mainfrom
yogeshmpandey:yogesh/feat/faqgen
Jul 24, 2024
Merged

FAQGen Megaservice#425
kevinintel merged 27 commits intoopea-project:mainfrom
yogeshmpandey:yogesh/feat/faqgen

Conversation

@yogeshmpandey
Copy link
Copy Markdown
Collaborator

Description

This PR introduces FAQGen Megaservice in GenAIExamples. Dependent on PR 318
in GenAIComps

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Test files to test on Xeon and Gaudi nodes

yogeshmpandey and others added 10 commits July 18, 2024 15:49
Signed-off-by: Yogesh Pandey <[email protected]>
Signed-off-by: Yogesh Pandey <[email protected]>
Signed-off-by: Yogesh Pandey <[email protected]>
Signed-off-by: Yogesh Pandey <[email protected]>
Signed-off-by: Yogesh Pandey <[email protected]>
Signed-off-by: Yogesh Pandey <[email protected]>
Signed-off-by: Yogesh Pandey <[email protected]>
Signed-off-by: Yogesh Pandey <[email protected]>
Signed-off-by: Yogesh Pandey <[email protected]>
@chensuyue chensuyue added this to the v0.8 milestone Jul 18, 2024
@kevinintel kevinintel linked an issue Jul 19, 2024 that may be closed by this pull request
@chensuyue
Copy link
Copy Markdown
Collaborator

chensuyue commented Jul 22, 2024

CI for this example only able to be test after opea-project/GenAIComps#318 merged.

@yogeshmpandey
Copy link
Copy Markdown
Collaborator Author

CI for this example only able to be test after opea-project/GenAIComps#318 merged.

@chensuyue I have the tests updated to pull the Comps from the PR itself, the tests run fine locally on Xeon and Gaudi. Not sure why they are failing here.

Signed-off-by: Yogesh Pandey <[email protected]>
Copy link
Copy Markdown
Collaborator

@WenjiaoYue WenjiaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI code (React, Svelte) is almost just renamed and copied from the content of docSum. So, what is the purpose of FAQGen? What improvements have been made, and are these improvements necessary to be provided to users as a complete repository? If the modifications are minor, can improvements be made in docSum or explained in docSum?

@yogeshmpandey
Copy link
Copy Markdown
Collaborator Author

The UI code (React, Svelte) is almost just renamed and copied from the content of docSum. So, what is the purpose of FAQGen? What improvements have been made, and are these improvements necessary to be provided to users as a complete repository? If the modifications are minor, can improvements be made in docSum or explained in docSum?

@WenjiaoYue , Since FAQGen needs special prompts to generate FAQs from the data, it is currently implemented as a different example. There is an ongoing discussion on consolidating the LLMs in upcoming releases. Later, we can update docsum to do summarization, FaqGen, meeting summary and other data insights from the same example.

@kevinintel kevinintel merged commit 8c4a253 into opea-project:main Jul 24, 2024
yogeshmpandey added a commit to hteeyeoh/GenAIExamples that referenced this pull request Aug 12, 2024
* Added FAQGEN v1

Signed-off-by: Yogesh Pandey <[email protected]>

---------

Signed-off-by: Yogesh Pandey <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
cogniware-devops pushed a commit to Cogniware-Inc/GenAIExamples that referenced this pull request Dec 19, 2025
* Added FAQGEN v1

Signed-off-by: Yogesh Pandey <[email protected]>

---------

Signed-off-by: Yogesh Pandey <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: cogniware-devops <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FAQGen

6 participants